-
Notifications
You must be signed in to change notification settings - Fork 421
feat(metrics): add EphemeralMetrics as a non-singleton option #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
heitorlessa
merged 6 commits into
aws-powertools:develop
from
heitorlessa:feat/disable-metrics-borg-pattern
Nov 1, 2022
Merged
feat(metrics): add EphemeralMetrics as a non-singleton option #1676
heitorlessa
merged 6 commits into
aws-powertools:develop
from
heitorlessa:feat/disable-metrics-borg-pattern
Nov 1, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still looking for a class name to avoid this implementation.
|
both Leandro and Ruben are PTO, therefore I'm merging after my best due diligence in review, docs, and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1668
Summary
By default,
Metrics
shares data across instances. This allows customers to instantiateMetrics
in multiple places throughout their code - be a separate file, a middleware, or an abstraction.However, there are three cases where this is a disadvantage:
Changes
This PR introduces a new class:
EphemeralMetrics
. This makes an explicit contract that instances ofEphemeralMetrics
will not share data sets (metrics, dimensions, metadata).Quick summary on differences:
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
log_metrics
use caseIs this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.